Skip to content

Remove homekit option#1023

Merged
bouwew merged 6 commits intomainfrom
remove-homekit
Feb 24, 2026
Merged

Remove homekit option#1023
bouwew merged 6 commits intomainfrom
remove-homekit

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Feb 23, 2026

Summary by CodeRabbit

  • Changed Features
    • Removed HomeKit emulation from the Plugwise climate integration; HVAC modes simplified and OFF handled directly while schedule behavior is preserved.
  • Configuration
    • Thermostat option for HomeKit emulation removed; related UI/translation entries cleaned up.
  • Tests
    • Updated test snapshots to include a new object_id_base field across multiple entity snapshots.
  • Changelog
    • Bumped release to v0.63.0.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7153999 and c676f20.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • custom_components/plugwise/manifest.json
  • pyproject.toml
✅ Files skipped from review due to trivial changes (2)
  • custom_components/plugwise/manifest.json
  • CHANGELOG.md

📝 Walkthrough

Walkthrough

Removes HomeKit emulation from the Plugwise integration: deletes config option and translation keys, removes the constructor parameter and internal HomeKit fields/helpers from the climate entity, and updates tests and snapshots to reflect these API/data-shape changes.

Changes

Cohort / File(s) Summary
Climate integration
custom_components/plugwise/climate.py
Removed HomeKit emulation imports and constructor parameter; dropped _homekit_enabled/_homekit_mode and helper _homekit_translate_or_not; simplified hvac_modes/hvac_mode and async_set_hvac_mode to no longer perform HomeKit-specific translation.
Config flow / options
custom_components/plugwise/config_flow.py
Removed CONF_HOMEKIT_EMULATION import and the HomeKit emulation option from the thermostat options schema and related default handling.
Translations / strings
custom_components/plugwise/strings.json, custom_components/plugwise/translations/en.json, custom_components/plugwise/translations/nl.json
Deleted options.step.init.data.homekit_emulation translation entries.
Tests — config flow
tests/components/plugwise/test_config_flow.py
Removed CONF_HOMEKIT_EMULATION usage in tests and updated expected options/form payloads to exclude HomeKit emulation.
Tests — snapshots
tests/components/plugwise/snapshots/*
(e.g., test_binary_sensor.ambr, test_button.ambr, test_climate.ambr, test_number.ambr, test_select.ambr, test_sensor.ambr, test_switch.ambr)
Appended object_id_base field to many EntityRegistryEntrySnapshot and some StateSnapshot entries across multiple snapshot files (test data shape change only).
Metadata / packaging
custom_components/plugwise/manifest.json, pyproject.toml, CHANGELOG.md
Bumped version to v0.63.0 and added changelog entry noting removal of HomeKit emulation.

Sequence Diagram(s)

(omitted — changes are feature removals and test/data updates; no new multi-component sequential flow introduced)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • CoMPaTech
  • github-actions
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove homekit option' directly and accurately describes the main change: removing HomeKit emulation features and the related configuration option throughout the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-homekit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot requested a review from CoMPaTech February 23, 2026 18:57
@coderabbitai coderabbitai bot added enhancement New feature or request needs_upstreaming Things that are here in -beta but must be upstreamed to HA-core labels Feb 23, 2026
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error while testing for Development HA-core:

⚠️ Warning: Incompatible while testing against dev HA-core.
✔️ Success: No problem with testing against released HA-core.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error while testing for Development HA-core:

⚠️ Warning: Incompatible while testing against dev HA-core.
✔️ Success: No problem with testing against released HA-core.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error while testing for Development HA-core:

⚠️ Warning: Incompatible while testing against dev HA-core.
✔️ Success: No problem with testing against released HA-core.

@bouwew bouwew changed the title Remove homekit Remove homekit option Feb 23, 2026
@sonarqubecloud
Copy link

Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I overlook something, looks good - just wondering where all the id changes in the snapshots come from?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error while testing for Development HA-core:

⚠️ Warning: Incompatible while testing against dev HA-core.
✔️ Success: No problem with testing against released HA-core.

@bouwew bouwew marked this pull request as ready for review February 23, 2026 19:32
@bouwew bouwew requested a review from a team as a code owner February 23, 2026 19:32
@coderabbitai coderabbitai bot requested a review from CoMPaTech February 23, 2026 19:32
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error while testing for Development HA-core:

⚠️ Warning: Incompatible while testing against dev HA-core.
✔️ Success: No problem with testing against released HA-core.

@bouwew bouwew merged commit 8951131 into main Feb 24, 2026
13 checks passed
@bouwew bouwew deleted the remove-homekit branch February 24, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request needs_upstreaming Things that are here in -beta but must be upstreamed to HA-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants