refactor(azure): remove unused config fields and Traefik Forward Auth#129
Open
refactor(azure): remove unused config fields and Traefik Forward Auth#129
Conversation
Remove 6 unused configuration fields from AzureWorkloadConfig: - client_id: Never referenced, managed identities created dynamically - secrets_provider_client_id: Only used by Traefik Forward Auth - instance_type: Replaced by node pool instance type configs - control_plane_node_count: Not applicable to managed AKS - worker_node_count: Replaced by node pool configs - db_storage_size_gb: Value hardcoded in implementation Remove Traefik Forward Auth support for Azure workloads: - Deleted traefik_forward_auth_azure.py - Removed integration from azure_workload_clusters.py - Feature required manual managed identity setup (broken/incomplete) - Feature hardcoded to Okta only - AWS Traefik Forward Auth support remains intact Updated tests to reflect removed fields.
stevenolen
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes unused configuration fields from
AzureWorkloadConfigand removes the incomplete/broken Traefik Forward Auth feature for Azure workloads.Changes
Removed 6 Unused Config Fields
The following fields were defined but never used in the codebase:
client_id/ClientID- Never referenced; managed identities are created dynamicallysecrets_provider_client_id/SecretsProviderClientID- Only used by Traefik Forward Auth (also removed)instance_type/InstanceType- Replaced by node pool instance type configscontrol_plane_node_count/ControlPlaneNodeCount- Not applicable to managed AKSworker_node_count/WorkerNodeCount- Replaced by node pool configsdb_storage_size_gb/DBStorageSizeGB- Value hardcoded to 128 in implementationRemoved Traefik Forward Auth for Azure Workloads
The Traefik Forward Auth feature for Azure was incomplete and broken:
Note: AWS Traefik Forward Auth support remains intact and functional.
Files Changed
lib/types/workload.go- Removed 6 fields fromAzureWorkloadConfiglib/types/workload_test.go- Updated testspython-pulumi/src/ptd/azure_workload.py- Removed 6 fieldspython-pulumi/src/ptd/pulumi_resources/azure_workload_clusters.py- Removed Traefik Forward Auth integrationpython-pulumi/src/ptd/pulumi_resources/traefik_forward_auth_azure.py- Deleted (117 lines)python-pulumi/tests/test_azure_bastion_config.py- Updated testsCategory of change
Testing
justruns cleanly