Get true lock_timeout #8
Open
+174
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgwatch sets lock_timeout to 100ms during metric collection, which causes the monitoring to report 100ms instead of the actual configured value. This fix queries reset_val from pg_settings for lock_timeout to get the genuine configuration value. Closes #61
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| case when setting ~ '^-?[0-9]+$' then setting::bigint else null end as numeric_value, | ||
| case when (case when name = 'lock_timeout' then reset_val else setting end) ~ '^-?[0-9]+$' then (case when name = 'lock_timeout' then reset_val else setting end)::bigint else null end as numeric_value, | ||
| case when source <> 'default' then 0 else 1 end as is_default, | ||
| 1 as configured |
There was a problem hiding this comment.
Bug: is_default inconsistent with lock_timeout value
For lock_timeout, tag_setting_value now comes from reset_val while is_default is still derived from source (the session-overridden value). When pgwatch sets lock_timeout during collection, source becomes session, causing is_default to report non-default even if the configured reset_val equals the default, making the emitted fields contradictory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pgwatch sets lock_timeout to 100ms during metric collection, which causes the monitoring to report 100ms instead of the actual configured value. This fix queries reset_val from pg_settings for lock_timeout to get the genuine configuration value.
Closes #61
Note
Report the actual lock_timeout by using reset_val in the settings metric and add unit/integration tests to verify it.
config/pgwatch-prometheus/metrics.yml):reset_valinstead ofsettingforlock_timeout(documented in description) and apply the same CASE logic fornumeric_value.tests/settings/test_settings_metric.pywith unit tests ensuring the SQL/description changes and an integration test validatinglock_timeoutreturns the reset value despite session overrides.Written by Cursor Bugbot for commit 7891edc. Configure here.