fix: replace moment with dayjs

[touchRED]

#731

Replaces Moment with DayJS, a 2kb library with an almost identical API.

Note:

• DayJS doesn't ship with an equivalent to Moment's parseFormat method used here. I'm not quite sure how long it could take to recreate this method, and I don't believe the moment-parseformat plugin can function without Moment installed. Thoughts?

[johnholdun]

Nice! There are tons of examples of real-world timestamps in the fixture files which we can test here as well. I think the best we can aim for here is an equal success rate against all those timestamps to what we were getting with moment.

[touchRED]

@johnholdun yep i'm running through all the tests now, realized moment was called in more of those than I expected. More to come!

[johnholdun]

I know this is how the old tests were too, but can we change all these expected dates into hard-coded strings? I think that would make the functionality we're testing more clear: we expect strings of varying format and quality, and we always return a string in a specific format.

So this line would become:

assert.equal(datePublished, '2020-01-01T00:00:00.000Z');

I think with that change we could probably remove dayjs as a dependency from this test file entirely.

[touchRED]

exactly, i'll have a commit with these changes shortly ✅

[touchRED]

@johnholdun clearly the updates we spoke about last week took significantly longer than I expected! Now that test-node is passing I'm going to clean things up, leave comments, etc. Question for you: in order to get test-web to pass, do I need to run yarn release and push up new dist files?

[appinteractive]

Hey is this issue still be worked on?