Track download size in ps_buckets
#160
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkistner
reviewed
Jan 27, 2026
Contributor
rkistner
left a comment
rkistner
left a comment
There was a problem hiding this comment.
I'm happy with tracking this in the ps_buckets table.
Do we already have something similar to track the number of operations we have downloaded for the bucket? I know we have count_at_last / count_since_last, but I believe those are reset when the checkpoint completes, so not quite the same?
We should also keep in mind there are some differences in tracking it here versus the current diagnostics client logic:
- Diagnostics client tracks empty buckets using the checkpoint data, this only tracks buckets when it has data. Empty buckets can be useful to see to distinguish parameter query / subquery issues from data query issues.
- The diagnostics client keeps the bucket download history around when removing buckets, while the ps_buckets row can be deleted (and potentially re-created) when the bucket is removed, or when there is a checksum failure.
| op_checksum = (op_checksum + ?4) & 0xffffffff, | ||
| count_since_last = count_since_last + ?5 | ||
| count_since_last = count_since_last + ?5, | ||
| download_size = download_size + ?6 |
Contributor
There was a problem hiding this comment.
Nitpick, but can we name the downloaded_size to make it clear it is tracking the data already downloaded, not future download size?
(I realize I'm that one that originally named it download_size in the diagnostics client...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
download_sizecolumn tops_buckets. It is initialized to0, the sync client increments it whenever it receives adataline for a particular bucket.This also helps with #155: By tracking this in the Rust client, SDKs won't have to decode lines to correlate buckets with original message sizes.