WIP: detect js by shebang and run by filetype#341
Open
coolaj86 wants to merge 3 commits intoprettier:masterfrom
Open
WIP: detect js by shebang and run by filetype#341coolaj86 wants to merge 3 commits intoprettier:masterfrom
coolaj86 wants to merge 3 commits intoprettier:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #340
Summary
Although these same lines work for me in my local config, This doesn't work directly in the vim-prettier plugin.
However, for someone who actually knows vimscript and how plugins work, I imagine understanding the intent and making the change for it to work will be trivial.
Test Plan
./test-no-extensionwith these contents:./test-no-extension:wIf it auto-formats, it worked.