Skip to content

Fix auto-install of pnpm and node on mode init #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephanmax wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix auto-install of pnpm and node on mode init #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07e5292
Fix auto-install of pnpm and node on mode init
stephanmax Jan 28, 2026
b5c7d88
Consider last line only when probing for command
stephanmax Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 40 additions & 12 deletions p5js/src/main/kotlin/p5jsEditor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,24 +63,55 @@ class p5jsEditor(base: Base, path: String?, state: EditorState?, mode: Mode?) :

createIndexHtml()

// TODO: refactor into functions, pick up crucial information from stdout
statusNotice("Looking for pnpm…")
val stackedStatusNotice = createStackedStatusNotice()
stackedStatusNotice("Looking for pnpm…")
try {
runCommand("pnpm -v")
val pnpmVersion = probeCommand("pnpm -v")
stackedStatusNotice("Found $pnpmVersion.")
} catch (e: Exception) {
statusNotice("pnpm not found. Installing pnpm…")
stackedStatusNotice("Not found. Installing pnpm…")
if (isWindows) {
runCommand("powershell -command \"Invoke-WebRequest https://get.pnpm.io/install.ps1 -UseBasicParsing | Invoke-Expression\"")
} else {
runCommand("chmod u+x ${mode?.folder}/install.sh")
runCommand("${mode?.folder}/install.sh")
}
stackedStatusNotice("Done.")
}

stackedStatusNotice("Looking for node…")
try {
val nodeVersion = probeCommand("node -v")
stackedStatusNotice("Found $nodeVersion.")
} catch (e: Exception) {
stackedStatusNotice("Not found. Installing node via pnpm…")

statusNotice("Installing Node via pnpm…")
runCommand("pnpm env use --global lts")

stackedStatusNotice("Done.")
}

statusNotice("All done! Enjoy p5.js mode.")
stackedStatusNotice("Enjoy p5.js mode!")
}
}

fun probeCommand(command: String): String {
val process = builder(command).start()
val exitCode = process.waitFor()

if (exitCode != 0) {
throw RuntimeException("Command failed with non-zero exit code $exitCode.")
}

val output = process.inputStream.bufferedReader().use { it.readLines().last() }
return output
}

fun createStackedStatusNotice(): (String) -> Unit {
var statusText = mutableListOf<String>()
return fun(text: String) {
statusText.add(text)
statusNotice(statusText.joinToString(" "))
}
}

Expand All @@ -102,8 +133,7 @@ class p5jsEditor(base: Base, path: String?, state: EditorState?, mode: Mode?) :
if (sketch.isUntitled || sketch.isReadOnly) {
Messages.showMessage("Save First", "Please first save the sketch.");
} else {
// TODO: I’m sure this is not the best way to ensure that this runs async, so the ActionListener can return
// but works for now
// TODO: I’m sure this is not the best way to ensure that this runs async, so the ActionListener can return but works for now
scope.launch {
handleExport()
}
Expand Down Expand Up @@ -336,7 +366,6 @@ class p5jsEditor(base: Base, path: String?, state: EditorState?, mode: Mode?) :
}
}


fun runCommand(action: String, directory: File = sketch.folder) {
try {
val processBuilder = builder(action, directory)
Expand All @@ -358,15 +387,14 @@ class p5jsEditor(base: Base, path: String?, state: EditorState?, mode: Mode?) :
}
}

private fun builder(action: String, directory: File): ProcessBuilder {
private fun builder(action: String, directory: File = sketch.folder): ProcessBuilder {
val processBuilder = ProcessBuilder()

// Set the command based on the operating system
val shell = System.getenv("SHELL")
val command = if (isWindows) {
listOf("cmd", "/c", action)
} else {
listOf(shell, "-ci", action)
listOf(System.getenv("SHELL"), "-ci", action)
}

processBuilder.command(command)
Expand Down