Fix joint passage reward function#167
Closed
Benabdellah22 wants to merge 4 commits intoproroklab:mainfrom
Benabdellah22:fix-joint-passage-reward-function
Closed
Fix joint passage reward function#167Benabdellah22 wants to merge 4 commits intoproroklab:mainfrom Benabdellah22:fix-joint-passage-reward-function
Benabdellah22 wants to merge 4 commits intoproroklab:mainfrom
Benabdellah22:fix-joint-passage-reward-function
Conversation
matteobettini
approved these changes
Oct 26, 2025
Member
matteobettini
left a comment
matteobettini
left a comment
There was a problem hiding this comment.
LGTM thanks so much! Only one question
vmas/scenarios/joint_passage.py
Outdated
| x_semidim=1, | ||
| y_semidim=1, | ||
| substeps=7 if not self.asym_package else 10, | ||
| substeps=2, # 7 if not self.asym_package else 10, |
Member
There was a problem hiding this comment.
Is this supposed to be here?
Contributor
Author
There was a problem hiding this comment.
i just reduced substeps to 2 for faster iteration, it's not supposed to be here
Member
|
We also need to update |
Member
|
We are missing the changes now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the joint passage reward function,
Previously, wall collisions were checked inside the passage loop, causing redundant and incorrect collision reward calculations.