Open
Conversation
jdnichollsc
force-pushed
the
feature/editor-coroutines
branch
from
7de038d to
55de6d4
Compare
Collaborator
|
@jdnichollsc, taking a look at it. |
Member
Author
|
To avoid this dependency maybe we can have another branch for this feature, what do you think? |
marcelochaves95
approved these changes
Jul 19, 2022
maifeeulasad
approved these changes
Jul 19, 2022
Collaborator
maifeeulasad
left a comment
maifeeulasad
left a comment
There was a problem hiding this comment.
It's awesome.
Just on a side note:
- Maybe we can add some examples, it may come in handy (I know it's more like, how to write an Editor scripts and all)
Maintaining multiple versions (with and without editor coroutines) could get quite complex. I think it's possible to support both cases using a conditional compilation flag — something like #if with a specific preprocessor define. Odin Serializer and Inspector use a similar approach with certain libraries. They then just notice about that in readme, so user will know he can use that and how to enable it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use EditorCoroutine option to support Editor Coroutines for a request