Use ValueError instead of IndexError in _degrees_to_index

[aman-coder03]

• Closes _degrees_to_index raises IndexError instead of ValueError for invalid inputs #2647
• I am familiar with the contributing guidelines
• Tests added
• Updates entries in docs/sphinx/source/reference for API changes.
• Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
• New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
• Pull request is nearly complete and ready for detailed review.
• Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Replaces IndexError with ValueError in _degrees_to_index for invalid
input values.

This aligns the exception type with Python and NumPy conventions and
improves API correctness without changing behavior.

Fixes #2647

[kandersolar]

@aman-coder03 the tests are failing, can you take a look?

[aman-coder03]

@kandersolar thanks for having a look
i will update the issues that are causing the test to fail soon!!

[Pradeepbeleri]

Hi, I would like to contribute this

[aman-coder03]

@Pradeepbeleri hi,
i have already changed the lines that are required

[aman-coder03]

The remaining failures are due to deprecation tests: "the tested function is scheduled to be removed in 0.14”.
@kandersolar

[aman-coder03]

@kandersolar all the tests are passing now. You can have a look now!

[aman-coder03]

@cwhanse i have implemented the changes

[cwhanse]

@cwhanse i have implemented the changes

Wrong PR for this comment, I think.

[aman-coder03]

@cwhanse i committed your suggestion (removing the pytest from line 3 as it is already present on line 9)😅

[aman-coder03]

is there any confusion from my end @cwhanse 😅

[cwhanse]

No, my mistake

[aman-coder03]

no issues! are there any additional changes required?

[echedey-ls]

I kind of miss adding this to the changelog (to be noted down for release preparation PR please) or even waiting for a minor release for coherency with backward compat changes. I'm okay with this as-is thou. Just so it's taken into account in the future. This change is unlikely to generate much problems downstream.