Add the shader source code to the shader() example#137
Open
villares wants to merge 1 commit intopy5coding:mainfrom
Open
Add the shader source code to the shader() example#137villares wants to merge 1 commit intopy5coding:mainfrom
villares wants to merge 1 commit intopy5coding:mainfrom
Conversation
Collaborator
|
This is a good idea, we should include the shader code. At a minimum it would make working wish shaders slightly less opaque. How to include it though? A solution here should also be compatible with what I come up with for unit tests. (Eventually) there will be unit tests based on the example code. |
Collaborator
Author
|
You have explained to me once how the reference is built, using data from
Processing... and I suppose there are tables to tweak stuff somewhere.
My first intuition is there should also be a folder with the code for each
example, the unit tests would run the sketch code and compare a resulting
image with the expected image. Some script would "include" the code into
some page source/template or build the final page (which also includes the
image). All this would create a complex workflow hard to explain...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @hx2A,
I should have opened an issue... I know this might not be the correct way of fixing this, but I'll open the PR anyway as a way of not forgetting about it and losing the code I retrieved from the Processing examples, which is used on this documentation item (while in the middle of doing something else).
Feel free to close this and/or to instruct me on how to do it properly, and I'll try at some other time 😄
... we should probably be discussing this in an issue, sorry!