feat: updates notebook dockerfile to avoid token #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MateoLostanlen
requested changes
Sep 25, 2025
Member
MateoLostanlen
left a comment
MateoLostanlen
left a comment
There was a problem hiding this comment.
Thanks for the change !
Please juste update the readme too
Member
Author
|
@MateoLostanlen Indeed, I had forgotten to update the readme. In any case, I will propose a major update to the readme soon (once s3 persistence PR is solved :) ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17
This PR adds parameter in notebook Dockerfile in order to avoid to register token when launching jupyter notebook for the first time.
In order to test, do not forget to rebuild the image (for ex via)
make buildthen run the services to see the update (for ex viadocker compose up notebooks -d