Open
Conversation
remove multiple api calls, use driver to execute js to mark status for better annotation on browserstack dashboard
ignore username/key from config file if those are default values and pick from env variables if available
Ankit098
force-pushed
the
bstack_session_status
branch
from
a35a06c to
583a4d3
Compare
Contributor
|
Thank you for this PR! Much appreciated! 🙏 I will hold off on merging it until the changes we have pending re Selenium4 has been merged. |
Contributor
Author
|
Hey, @BeyondEvil do we have an ETA for the changes to be merged? |
Contributor
Author
|
ping @BeyondEvil .. |
Contributor
Thanks for pinging! I've been superbusy, will try to get to this ASAP tho. |
Contributor
Author
|
@BeyondEvil bump for this.. |
Contributor
Author
|
bump^ any updates on this? |
Contributor
Hey, sorry for not getting to this yet. 😓 I’m still working on the rewrite and release of the next major release of pytest-html. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-> Removed extra attempts to mark status
-> Use javascript executor before session quit rather than making a rest api call after session end for visibility on dashboard.