Clean up capture code #14160
Open
Clean up capture code #14160
+29
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liam-DeVoe
commented
Feb 3, 2026
Comment on lines
-377
to
386
| def repr(self, class_name: str) -> str: | ||
| return "<{} {} _old={} _state={!r} tmpfile={!r}>".format( | ||
| class_name, | ||
| self.name, | ||
| (hasattr(self, "_old") and repr(self._old)) or "<UNSET>", | ||
| self._state, | ||
| self.tmpfile, | ||
| ) | ||
|
|
||
| def __repr__(self) -> str: |
Contributor
Author
There was a problem hiding this comment.
Introduced in 97bcf5a. Duplicates __repr__ and seems unused?
Pierre-Sassoulas
added
the
skip news
Member
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
LGTM but the two commits should have a better description imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.