Resolve field aliases before calling field_transformer #1509
+125
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1479
_privatetoprivate) to before thefield_transformercallback, so transformers receive fully populatedAttributeobjects with usablealiasvalues instead ofNone.Attribute.evolve()to automatically update the alias when thenamechanges, if the alias was auto-generated (matches the default for the old name). Explicit aliases are preserved.Before (broken)
After (fixed)
Test plan
test_hook_alias_available- verifies transformer sees resolved aliasestest_hook_evolve_name_updates_auto_alias- verifiesevolve(name=...)updates auto-generated aliastest_hook_evolve_name_keeps_explicit_alias- verifiesevolve(name=...)preserves explicit aliasNone🤖 Generated with Claude Code