Use standard library timezone instead of FixedOffsetTimezone
#1203
+38
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1203 +/- ##
==========================================
- Coverage 91.71% 91.69% -0.03%
==========================================
Files 27 27
Lines 4696 4696
==========================================
- Hits 4307 4306 -1
- Misses 389 390 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tomasr8
reviewed
Mar 20, 2025
| """ | ||
| Fixed offset in minutes east from UTC. | ||
| DEPRECATED: Use the standard library `datetime.timezone` instead. |
Member
There was a problem hiding this comment.
(Drive-by review, I'll try to review this thoroughly later) We could also add a module getter that raises a deprecation warning when this class is accessed/imported (or even when it's instantiated maybe?)
akx
force-pushed
the
fixed-offset-tz
branch
2 times, most recently
from
cd1dfb7 to
c16c01a
Compare
tomasr8
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed
FixedOffsetTimezones didn't unpickle, and then realized we shouldn't use them at all.