Skip to content

Include duplicate indices and value in uniqueItems error message #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daniel7an wants to merge 1 commit into from
Closed

Include duplicate indices and value in uniqueItems error message #1453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion jsonschema/_keywords.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,28 @@ def uniqueItems(validator, uI, instance, schema):
and validator.is_type(instance, "array")
and not uniq(instance)
):
yield ValidationError(f"{instance!r} has non-unique elements")
# Find the first pair of duplicate items and their indices
seen = []
indices = None
for i, item in enumerate(instance):
for j, seen_item in enumerate(seen):
if equal(item, seen_item):
indices = (j, i)
break
if indices is not None:
break
seen.append(item)

if indices is not None:
first, second = indices
msg = (
f"{instance!r} has non-unique elements"
f" (items at index {first} and {second}"
f" are equal: {instance[first]!r})"
)
else:
msg = f"{instance!r} has non-unique elements"
yield ValidationError(msg)


def pattern(validator, patrn, instance, schema):
Expand Down
Loading