Open
Conversation
Collaborator
Author
|
@NickHallONBI - can you test this with the hardware when you get a chance? |
Collaborator
|
Testing today on the cryo Aurox setup appears to work. One problem is the docstring.. Config sample: The camera module is a python object not a string so shouldn't be in quotes. |
Collaborator
|
I started looking into this and merge into master but then noticed that while we import |
Collaborator
|
Exactly my question. We should merge what works and close the other issues. |
dstoychev
pushed a commit
to dstoychev/microscope
that referenced
this pull request
Nov 3, 2020
dstoychev
pushed a commit
to dstoychev/microscope
that referenced
this pull request
Dec 15, 2020
dstoychev
pushed a commit
to dstoychev/microscope
that referenced
this pull request
Dec 15, 2020
dstoychev
pushed a commit
to dstoychev/microscope
that referenced
this pull request
Dec 15, 2020
dstoychev
pushed a commit
to dstoychev/microscope
that referenced
this pull request
Dec 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs testing with hardware
An alternative implementation for #121, replacing #124.
The camera is augmented with methods to do data processing and return the correct image shape depending on processing mode. Camera parameters are passed as a dict, to avoid the dot-notation problem discussed in #124.