mypy strict mode #9410
Open
mypy strict mode #9410
+117
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Jan 27, 2026
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
radarhere
reviewed
Jan 30, 2026
| disallow_untyped_calls = false | ||
| enable_error_code = "ignore-without-code" | ||
| extra_checks = true | ||
| follow_imports = "silent" |
Member
There was a problem hiding this comment.
I don't see anything at https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-strict that mentions follow_imports? What was the thinking behind changing this?
Author
There was a problem hiding this comment.
That's right, follow_imports is unrelated to --strict. It's just unnecessary to suppress those import errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configures mypy to run in "strict mode", which according to
mypy --helpenables the following flags:Enabling this caused a bunch of typing errors to surface, which are now also fixed.
Most of these are related to
bytes/bytearray/memoryviewnot being assignable to each other. So I used their common denominator,collections.abc.Buffer, or rather its backport fromtyping_extensions(which is always availableif TYPE_CHECKINGbecause typeshed conveniently lies that it's part of the standard library).