-
-
Notifications
You must be signed in to change notification settings - Fork 34.1k
gh-140715: Update datetime.*.str*time format code tables
#140716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Maybe @serhiy-storchaka could you please review? |
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a separate column for strptime support? Most of codes are supported in strptime. Support of some of them was added as a part of bugfixes for %c (for example, %e is supported). More will be added in 3.15. For remaining, it is easier to list these that are not supported separately, or add a special footnote for them.
|
I replaced it with a footnote.
Indeed, I will open PRs for the rest, there is one already for |
encukou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a nitpick, looks good!
I found a related issue for a new PR: #70647 (comment)
Co-authored-by: Petr Viktorin <encukou@gmail.com>
| Notes: | ||
|
|
||
| (0) | ||
| This format code is currently unsupported by :meth:`~.datetime.strptime`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Musing: I have thought about making these footnots actual activable references.
Do you think it would be a good idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See issue #137742, which I just commented on a few seconds ago 😆
str*timeto C11 format codes #140715📚 Documentation preview 📚: https://cpython-previews--140716.org.readthedocs.build/