Skip to content

gh-143164: Fix incorrect error message for ctypes bitfield overflow #143165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 7 commits into from
Dec 25, 2025
Merged

gh-143164: Fix incorrect error message for ctypes bitfield overflow #143165

serhiy-storchaka merged 7 commits into from
Dec 25, 2025
+18 −2

Conversation

@hyongtao-code
Copy link
Contributor

@hyongtao-code hyongtao-code commented Dec 25, 2025 •
edited by bedevere-app bot
Loading

The previous message did not match the actual overflow check and omitted the bitfield size, making it misleading. Update the message to reflect the correct condition and report all relevant values.

@hyongtao-code
Fix incorrect error message for ctypes bitfield overflow.
08dd04e 
The previous message did not match the actual overflow check and omitted
the bitfield size, making it misleading. Update the message to reflect the
correct condition and report all relevant values.

Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
@bedevere-app bedevere-app bot mentioned this pull request Dec 25, 2025
Closed
@aisk
Copy link
Contributor

aisk commented Dec 25, 2025

Maybe we can add a test to check the message to ensure that we don't break it up in the future?

@hyongtao-code
Copy link
Contributor Author

hyongtao-code commented Dec 25, 2025

Maybe we can add a test to check the message to ensure that we don't break it up in the future?

Thanks for the review! The test case has now been added.

aisk
aisk reviewed Dec 25, 2025
View reviewed changes
@hyongtao-code @aisk
Update Lib/test/test_ctypes/test_struct_fields.py
96f72e8 
Co-authored-by: AN Long <aisk@users.noreply.github.com>
serhiy-storchaka
serhiy-storchaka reviewed Dec 25, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

I have a suggestion for test example.

serhiy-storchaka
serhiy-storchaka reviewed Dec 25, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the message should be updated too.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 25, 2025
@hyongtao-code
Copy link
Contributor Author

hyongtao-code commented Dec 25, 2025

I think the message should be updated too.

Updated, thanks for the feedback.

serhiy-storchaka
serhiy-storchaka reviewed Dec 25, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for misleading. I meant the error message tested in the test should be updated. Otherwise the test will fail.

@hyongtao-code
Copy link
Contributor Author

hyongtao-code commented Dec 25, 2025

Oh, sorry for my mistake. Updated it.

@serhiy-storchaka serhiy-storchaka merged commit b9a4806 into python:main Dec 25, 2025
46 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 25, 2025

Thanks @hyongtao-code for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 25, 2025
@hyongtao-code @miss-islington
pythongh-143164: Fix incorrect error message for ctypes bitfield over…
29dc991 
…flow (pythonGH-143165)

(cherry picked from commit b9a4806)

Co-authored-by: Yongtao Huang <yongtaoh2022@gmail.com>
Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 25, 2025

Sorry, @hyongtao-code and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b9a48064306229287d7211e9510f578065e457fc 3.13

@bedevere-app
Copy link

bedevere-app bot commented Dec 25, 2025

GH-143176 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 25, 2025
serhiy-storchaka pushed a commit that referenced this pull request Dec 25, 2025
@miss-islington @hyongtao-code
[3.14] gh-143164: Fix incorrect error message for ctypes bitfield ove…
723ed8c 
…rflow (GH-143165) (GH-143176)

(cherry picked from commit b9a4806)

Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
Co-authored-by: Yongtao Huang <yongtaoh2022@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@serhiy-storchaka serhiy-storchaka

Labels

needs backport to 3.13 bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hyongtao-code @aisk @serhiy-storchaka