gh-142927: Auto-open HTML output in browser after generation

[ivonastojanovic]

Automatically open flamegraph and heatmap HTML output in the default browser after profiling completes. Add --no-browser flag to disable this behavior.

Towards #142927.

CC: @pablogsal @lkollar

• Issue: Implement PEP 799 – A dedicated profiling package for organizing Python profiling tools #138122

• Issue: Improve Tachyon UX #142927

[pablogsal]

You probably need to update the test to NOT open the browser by default and make the CLI the only that sets that option to True :)

[pablogsal]

Changing the issue to gh-142927

[pablogsal]

And we also need to mention something related to this behavior in the docs

[pablogsal]

Some tests re opening browsers now 😆

You probably want this diff at least:

diff --git a/Lib/test/test_profiling/test_sampling_profiler/test_children.py b/Lib/test/test_profiling/test_sampling_profiler/test_children.py
index b7dc878a238..3d6db7dcb56 100644
--- a/Lib/test/test_profiling/test_sampling_profiler/test_children.py
+++ b/Lib/test/test_profiling/test_sampling_profiler/test_children.py
@@ -992,6 +992,7 @@ def test_subprocesses_flag_with_flamegraph_output(self):
                     "-r",
                     "100",
                     "--flamegraph",
+                    "--no-browser",
                     "-o",
                     output_file,
                     script_file,

[danielhollas]

Hey, 👋

sorry for a drive-by comment, just wanted to chime in with a specific use case: the default behaviour you're introducing here is suuuper annoying when being logged in via SSH (and based on my experience it's too easy to forget the --no-browser option 🙈).

According to (this post)[https://unix.stackexchange.com/a/9607], it might be possible (at least on best effort basis) to check some environment variables to detect the SSH connection, and perhaps disable the browser-opening automatically in that case?

If that sounds reasonable I can do a bit of testing for SSH detection tomorrow. The biggest disadvantage I see that it would make the default behaviour less trivial to explaing to users...