-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
gh-142461: Move misplaced NEWS entries to an appropriate section #143392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Misc/NEWS.d/3.12.0a1.rst
Outdated
| .. gh-issue: 95185 | ||
| .. nonce: ghYTZx | ||
| .. section: Core and Builtins | ||
| .. section: Library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is wrong, it was fixing the parser?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for pointing out.
picnixz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
astis a core module,- import machinery is a core component
Misc/NEWS.d/3.12.0a1.rst
Outdated
| .. gh-issue: 86298 | ||
| .. nonce: QVM7G1 | ||
| .. section: Core and Builtins | ||
| .. section: Library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a core and builtins stuff.
Misc/NEWS.d/3.12.0a1.rst
Outdated
| .. gh-issue: 93351 | ||
| .. nonce: 0Jyvu- | ||
| .. section: Core and Builtins | ||
| .. section: Library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ast is a core module. Revert.
Misc/NEWS.d/3.12.0a2.rst
Outdated
| .. gh-issue: 98415 | ||
| .. nonce: ZS2eWh | ||
| .. section: Core and Builtins | ||
| .. section: Library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to Build
Misc/NEWS.d/3.12.0a7.rst
Outdated
| .. gh-issue: 102406 | ||
| .. nonce: XLqYO3 | ||
| .. section: Core and Builtins | ||
| .. section: Library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should likely stay in "Core and Builtins".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll keep it in "Core and Builtins" (codecs.c changes).
Misc/NEWS.d/3.12.0a7.rst
Outdated
| .. gh-issue: 102027 | ||
| .. nonce: fQARG0 | ||
| .. section: Core and Builtins | ||
| .. section: Library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move it to "Build"
Misc/NEWS.d/3.13.0a6.rst
Outdated
| .. gh-issue: 117266 | ||
| .. nonce: Kwh79O | ||
| .. section: Core and Builtins | ||
| .. section: Library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep it.
Misc/NEWS.d/3.13.0a5.rst
Outdated
| .. gh-issue: 105858 | ||
| .. nonce: Q7h0EV | ||
| .. section: Core and Builtins | ||
| .. section: Library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep it.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
| .. gh-issue: 94869 | ||
| .. nonce: eRwMsX | ||
| .. section: Core and Builtins | ||
| .. section: Library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a core and built-in. Other changes to ast are Library because they affect the pure python part of ast.parse.
| .. gh-issue: 93359 | ||
| .. nonce: zXV3A0 | ||
| .. section: Core and Builtins | ||
| .. section: Library |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this one is a core and builtins.
This includes changes in 3.12 and 3.13