gh-143414: Implement unique reference tracking for JIT, optimize unpacking of such tuples #144300
+1,079
−876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidenong
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
cocolato
reviewed
Jan 28, 2026
Contributor
Author
|
Discussed with @Fidget-Spinner, will reopen the PR after implementing |
Member
|
Windows Ci failure looks possibly related, can you please look into it? |
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
This is excellent. Just 2 comments, then I think it's safe to merge.
| static inline JitOptRef | ||
| PyJitRef_StripBorrowInfo(JitOptRef ref) | ||
| { | ||
| if (PyJitRef_IsUnique(ref)) return ref; |
Member
There was a problem hiding this comment.
Please follow PEP 7 and use curly braces around this.
|
|
||
| op(_COPY, (bottom, unused[oparg-1] -- bottom, unused[oparg-1], top)) { | ||
| assert(oparg > 0); | ||
| bottom = PyJitRef_IsUnique(bottom) ? PyJitRef_StripReferenceInfo(bottom) : bottom; |
Member
There was a problem hiding this comment.
We only need to strip unique info here, not the borrow info too. This way we still get refcount elimination with the borrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes:
_BUILD_TUPLE, to be extended to other objects in the future_LOAD_FAST_*and_COPY.Would appreciate any feedback.
Thanks
unique reference trackingin Tier 2 for reference count optimizations #143414