Skip to content

gh-140550: allow slots that repeat information from PyModuleDef #144340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
encukou wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-140550: allow slots that repeat information from PyModuleDef #144340

encukou wants to merge 2 commits into from
+134 −48

Conversation

@encukou
Copy link
Member

@encukou encukou commented Jan 30, 2026 •
edited by github-actions bot
Loading

From feedback on the discussion thread:

When integrating slots-based module creation is with the inittab, which currently requires PyModuleDef, it would be convenient to reuse the the same slots array for the MethodDef.

This PR allows slots that match what's already present in the PyModuleDef.

cc @ngoldbaum

📚 Documentation preview 📚: https://cpython-previews--144340.org.readthedocs.build/

@encukou
pythongh-140550: allow slots that repeat information from PyModuleDef
48ab83f 
When integrating slots-based module creation is with the inittab,
which currently requires PyModuleDef, it would be convenient to
reuse the the same slots array for the MethodDef.

Allow slots that match what's already present in the PyModuleDef.
@bedevere-app bedevere-app bot mentioned this pull request Jan 30, 2026
Open
25 tasks
@encukou encukou marked this pull request as draft January 30, 2026 12:55
@ngoldbaum
Copy link
Contributor

ngoldbaum commented Jan 30, 2026 •
edited
Loading

I can confirm that with this PR the PyO3 tests all pass on my for-petr branch, which uses the same slots array for both initialization hooks and unconditionally sets m_name and m_doc in PyModuleDef. It's fine for PyO3's purposes to have duplicate information with this check to make sure that the duplicate information matches exactly.

@ngoldbaum ngoldbaum mentioned this pull request Jan 30, 2026
Open
@encukou encukou marked this pull request as ready for review January 30, 2026 15:23
encukou
encukou commented Jan 30, 2026
View reviewed changes
encukou
encukou commented Jan 30, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@encukou @ngoldbaum