Skip to content

gh-144173: fix flaky test_complex.test_truediv() #144355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skirpichev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-144173: fix flaky test_complex.test_truediv() #144355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 20 additions & 21 deletions Lib/test/test_complex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ def assertAlmostEqual(self, a, b):
else:
unittest.TestCase.assertAlmostEqual(self, a, b)

def assertCloseAbs(self, x, y, eps=1e-9):
"""Return true iff floats x and y "are close"."""
def assertClose(self, x, y, eps=1e-9):
"""Return true iff complexes x and y "are close"."""
# put the one with larger magnitude second
if abs(x) > abs(y):
x, y = y, x
Expand All @@ -82,26 +82,15 @@ def assertCloseAbs(self, x, y, eps=1e-9):
if x == 0:
return abs(y) < eps
# check that relative difference < eps
self.assertTrue(abs((x-y)/y) < eps)

def assertClose(self, x, y, eps=1e-9):
"""Return true iff complexes x and y "are close"."""
self.assertCloseAbs(x.real, y.real, eps)
self.assertCloseAbs(x.imag, y.imag, eps)
self.assertTrue(abs(x-y)/abs(y) < eps)

def check_div(self, x, y):
"""Compute complex z=x*y, and check that z/x==y and z/y==x."""
z = x * y
if x != 0:
q = z / x
self.assertClose(q, y)
q = z.__truediv__(x)
self.assertClose(q, y)
if y != 0:
q = z / y
self.assertClose(q, x)
q = z.__truediv__(y)
self.assertClose(q, x)
if x:
self.assertClose(z / x, y)
if y:
self.assertClose(z / y, x)

def test_truediv(self):
simple_real = [float(i) for i in range(-5, 6)]
Expand All @@ -115,10 +104,20 @@ def test_truediv(self):
self.check_div(complex(1e200, 1e200), 1+0j)
self.check_div(complex(1e-200, 1e-200), 1+0j)

# Smith's algorithm has several sources of inaccuracy
# for components of the result. In examples below,
# it's cancellation of digits in computation of sum.
self.check_div(1e-09+1j, 1+1j)
self.check_div(8.289760544677449e-09+0.13257307440728516j,
0.9059966714925808+0.5054864708672686j)

# Just for fun.
for i in range(100):
self.check_div(complex(random(), random()),
complex(random(), random()))
x = complex(random(), random())
y = complex(random(), random())
self.check_div(x, y)
y = complex(1e10*y.real, y.imag)
self.check_div(x, y)

self.assertAlmostEqual(complex.__truediv__(2+0j, 1+1j), 1-1j)
self.assertRaises(TypeError, operator.truediv, 1j, None)
Expand Down Expand Up @@ -454,7 +453,7 @@ def test_boolcontext(self):
self.assertTrue(1j)

def test_conjugate(self):
self.assertClose(complex(5.3, 9.8).conjugate(), 5.3-9.8j)
self.assertEqual(complex(5.3, 9.8).conjugate(), 5.3-9.8j)

def test_constructor(self):
def check(z, x, y):
Expand Down
Loading