Remove PYEXPAT_EXPORTS usage from PCBuild/pyexpat.vcxproj#144462
Merged
zooba merged 1 commit intopython:mainfrom Feb 3, 2026
Merged
Remove PYEXPAT_EXPORTS usage from PCBuild/pyexpat.vcxproj#144462zooba merged 1 commit intopython:mainfrom
PYEXPAT_EXPORTS usage from PCBuild/pyexpat.vcxproj#144462zooba merged 1 commit intopython:mainfrom
Conversation
Contributor
Author
|
Possibly this stems from libexpat having an |
PYEXPAT_EXPORTS usage from PCBuild/pyexpat.vcxproj
Member
|
cc @hartwork |
Member
|
Seems trivial to me, I don't see any uses of the variable anywhere. |
Contributor
|
Throughout Expat upstream Git history, # git log -p -G EXPAT_EXPORTS | lsdiff --strip=1 | sort -u
expat/bcb5/expat.bpr
expat/bcb5/expat.mak
expat/bcb5/expatw.bpr
expat/bcb5/expatw.mak
expat/bcb5/libexpat.bpr
expat/bcb5/libexpat.mak
expat/bcb5/libexpatw.bpr
expat/bcb5/libexpatw.mak
expat/lib/expat.dsp
expat/lib/expatw.dspAnd in CPython: # git log -p -G PYEXPAT_EXPORTS | lsdiff --strip=1 | sort -u
PCbuild8/pyexpat/pyexpat.vcproj
PCbuild9/pyexpat.vcproj
PCbuild/pyexpat.vcproj
PCbuild/pyexpat.vcxproj
PC/VS8.0/pyexpat.vcproj
PC/VS9.0/pyexpat.vcprojI think it's safe to remove. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking through the history I was unable to find any revision where this actually did anything.
This should be a trivial enough change that it doesn't require a separate issue/news entry