gh-144386: Update equivalent code for "with", "async with" and "async for"#144472
Open
serhiy-storchaka wants to merge 1 commit intopython:mainfrom
Open
gh-144386: Update equivalent code for "with", "async with" and "async for"#144472serhiy-storchaka wants to merge 1 commit intopython:mainfrom
serhiy-storchaka wants to merge 1 commit intopython:mainfrom
Conversation
…"async for" They use special method lookup for special methods.
Contributor
|
I happened to notice that there might be a small point to adjust. The updated equivalent code import sys
class CM:
def __init__(self):
def __enter__():
pass
def __exit__(*exc_details):
pass
self.__enter__ = __enter__
self.__exit__ = __exit__
# Not works: TypeError: 'CM' object does not support the context manager protocol (missed __exit__ method)
with CM():
pass
# Works
manager = CM()
enter = manager.__enter__
exit_ = manager.__exit__
value = enter()
hit_except = False
try:
TARGET = value
except:
hit_except = True
if not exit(*sys.exc_info()):
raise
finally:
if not hit_except:
exit_(None, None, None) |
Member
Author
|
Yes, this is what the added note for. |
Contributor
|
Oops, I missed that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They use special method lookup for special methods.
ExitStack.enter_context#144386📚 Documentation preview 📚: https://cpython-previews--144472.org.readthedocs.build/