Skip to content

[3.14] gh-138744: Upgrade Windows to 2025 in GitHub Actions #144669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vstinner wants to merge 2 commits into from
Closed

[3.14] gh-138744: Upgrade Windows to 2025 in GitHub Actions #144669

vstinner wants to merge 2 commits into from
+8 −8

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Feb 10, 2026 •
edited by bedevere-app bot
Loading

Replace windows-2022 with windows-2025.

@vstinner
pythongh-138744: Upgrade Windows to 2025 in GitHub Actions
9d53eaa 
Replace windows-2022 with windows-2025.
@bedevere-app bedevere-app bot mentioned this pull request Feb 10, 2026
Open
@vstinner
Copy link
Member Author

vstinner commented Feb 10, 2026

I skipped test_dtrace on Windows in the 3.14 branch: #144657. So tests should pass again on Windows 2025.

@vstinner
Copy link
Member Author

vstinner commented Feb 10, 2026

cc @Fidget-Spinner

StanFromIreland
StanFromIreland reviewed Feb 10, 2026
View reviewed changes
@vstinner vstinner marked this pull request as draft February 10, 2026 14:50
@vstinner
Copy link
Member Author

vstinner commented Feb 10, 2026

The Windows CI was skipped since my PR only modify files of the .github/ directory. I mark my PR as a draft and modify a random file (Lib/test/test_dtrace.py) to trigger the Windows CI.

@vstinner
Copy link
Member Author

vstinner commented Feb 10, 2026

All Windows CIs passed. Examples:

JIT / i686-pc-windows-msvc/msvc (Debug) (pull_request)
JIT / i686-pc-windows-msvc/msvc (Release) (pull_request)
JIT / x86_64-pc-windows-msvc/msvc (Debug) (pull_request)
JIT / x86_64-pc-windows-msvc/msvc (Release) (pull_request)
Tail calling interpreter / x86_64-pc-windows-msvc/msvc (pull_request)
Tests / Windows (free-threading) / Build and test (arm64) (pull_request)
Tests / Windows (free-threading) / Build and test (x64) (pull_request)
Tests / Windows / Build and test (arm64) (pull_request)
Tests / Windows / Build and test (Win32) (pull_request)
Tests / Windows / Build and test (x64) (pull_request)
Tests / Windows MSI / installer for arm64 (pull_request)
Tests / Windows MSI / installer for x64 (pull_request)
Tests / Windows MSI / installer for x86 (pull_request)

hugovk
hugovk reviewed Feb 10, 2026
View reviewed changes
.github/workflows/reusable-windows-msi.yml
build:
name: installer for ${{ inputs.arch }}
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2022' }}
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2025' }}
Copy link
Member

@hugovk hugovk Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make this change in main?

.github/workflows/reusable-windows.yml
build:
name: Build and test (${{ inputs.arch }})
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2022' }}
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2025' }}
Copy link
Member

@hugovk hugovk Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this in main?

.github/workflows/jit.yml
- target: i686-pc-windows-msvc/msvc
architecture: Win32
runner: windows-2022
runner: windows-2025
Copy link
Member

@hugovk hugovk Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this in main?

.github/workflows/jit.yml
- target: x86_64-pc-windows-msvc/msvc
architecture: x64
runner: windows-2022
runner: windows-2025
Copy link
Member

@hugovk hugovk Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this?

@vstinner
Copy link
Member Author

vstinner commented Feb 10, 2026

Oh, I misunderstood the commit 25e99b3. I expected that it already upgraded Windows to 2025 for all CI jobs, but in fact it only changes "Windows tailcall CI".

I closed this PR to redo the change in the main branch first: #144682.

@vstinner vstinner closed this Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments

@hugovk hugovk hugovk left review comments

@StanFromIreland StanFromIreland StanFromIreland left review comments

@webknjaz webknjaz webknjaz approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner

@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @ambv @webknjaz @hugovk @StanFromIreland