[mypyc] Add irbuild support for vec types #20724
Open
+2,175
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some vec[i64] features are supported at the moment, but things are still very incomplete.
Also add Undef value type that can currently only used as the operand for SetElement to signify that we are creating a new value instead of modifying an existing value.
Use a common base class 'vec' for isinstance support. The base class is currently only used for isinstance, but we could add some other basic functionality there in the future.
p-sawicki
reviewed
Feb 2, 2026
|
|
||
|
|
||
| def is_pointer_arithmetic(op: IntOp) -> bool: | ||
| """Check if op is add/subtract targeting pointer_rprimtive and integer of the same size.""" |
Collaborator
There was a problem hiding this comment.
Suggested change
| """Check if op is add/subtract targeting pointer_rprimtive and integer of the same size.""" | |
| """Check if op is add/subtract targeting pointer_rprimitive and integer of the same size.""" |
| "object_ptr", is_unboxed=False, is_refcounted=False, ctype="PyObject **" | ||
| ) | ||
|
|
||
| # Similar to object_primitive, but doesn not use automatic reference |
Collaborator
There was a problem hiding this comment.
Suggested change
| # Similar to object_primitive, but doesn not use automatic reference | |
| # Similar to object_primitive, but does not use automatic reference |
| return RVec(deserialize_type(data["item_type"], ctx)) | ||
|
|
||
|
|
||
| def vec_depth(t: RVec) -> int: |
Comment on lines
+1325
to
+1326
| names=["ob_base", "len", "items"], | ||
| types=[PyVarObject, int64_rprimitive], |
Collaborator
There was a problem hiding this comment.
items is missing a type here and in the other buf objects for primitives.
mypyc/ir/rtypes.py
Outdated
| bool_rprimitive: "VecBoolApi", | ||
| } | ||
|
|
||
| # These are special type item type contants used in nested vecs to represent |
Collaborator
There was a problem hiding this comment.
Suggested change
| # These are special type item type contants used in nested vecs to represent | |
| # These are special item type constants used in nested vecs to represent |
| item_addr = vec_item_ptr(builder, base, index) | ||
| result = builder.load_mem(item_addr, vtype.item_type, borrow=can_borrow) | ||
| builder.keep_alives.append(base) | ||
| return result |
Collaborator
There was a problem hiding this comment.
aside from the index check this is very similar to the unsafe function, could it be called here?
Comment on lines
+463
to
+467
| elif vec_depth(vec_type) == 0 and not isinstance(item_type, RUnion): | ||
| name = "VecTApi.remove" | ||
| else: | ||
| coerced_item = convert_to_t_ext_item(builder, coerced_item) | ||
| name = "VecNestedApi.remove" |
Collaborator
There was a problem hiding this comment.
does this mean that for vecs with optional types we use the API for nested vecs? i thought it would be vecT. same pattern in vec_slice but not in other functions.
Comment on lines
+331
to
+336
| r0 = VecI64Api.alloc(0, 0) | ||
| r1 = r0 | ||
| r2 = 0 | ||
| x = r2 | ||
| L1: | ||
| r3 = r2 < 5 :: signed |
Collaborator
There was a problem hiding this comment.
it probably won't matter much, but if we can tell that there will be 5 elements, we should be able to pre-allocate the vector.
Comment on lines
+469
to
+475
| r0 = VecI64Api.alloc(0, 0) | ||
| r1 = r0 | ||
| r2 = 0 | ||
| r3 = r2 >> 1 | ||
| ___tmp_5 = r3 | ||
| L1: | ||
| r4 = int_lt r2, 14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic irbuild support for
vec[t]. The runtime representation ofvec[t]is a C struct. This is similar to how fixed-length tuples are represented. Multiple different structs are used, depending on the item type (VecI32forvec[i32] and so on).The C extension
librt.vecthat defines thevectype was added in #20653 and #20656. These PRs also explain the implementation in more detail.Add RType subclass RVec that is used for vecs. We need a new RType class, since primitives types can't be generic and they can't be struct types.
This is based on an old branch, so it mostly uses old-style primitives. I am planning to modernize some of the primitives in follow-up PRs.
This doesn't include codegen support, and irbuild test cases are only included for
vec[i64]. I will create follow-up PRs that add the remaining irbuild tests, codegen support and run tests. All these tests are are passing on my local full branch.Related issue: mypyc/mypyc#840