Draft
Conversation
randolf-scholz
force-pushed
the
relax_overload_subtyping
branch
from
ff95659 to
e5b2785
Compare
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pywin32 (https://github.com/mhammond/pywin32)
+ win32/Lib/win32timezone.py:1160: error: Unused "type: ignore" comment [unused-ignore]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20720
added a new flag
--strict-overload-subtyping:when this flag is not set then subtypes can change the overload order compared to supertypes.
added a test based on the cases in Relax default overload subtyping checks #20720
This is a first round proof of concept to see what the primer finds.
A possible refinement is to only allow overload order swapping if the supertype comes from a
Protocol. But I am not quite sure if its always possible to easily tell if that's the case.