Fix #2626: Fix Multi Year String Render For Single Day Events#2627
Open
alvindera97 wants to merge 4 commits intopython:mainfrom
Open
Fix #2626: Fix Multi Year String Render For Single Day Events#2627alvindera97 wants to merge 4 commits intopython:mainfrom
alvindera97 wants to merge 4 commits intopython:mainfrom
Conversation
Add test that checks single day event renders year string exactly once since event is guaranteed to commence and conclude within the same day and hence the same year.
Add test that checks for proper year string rendering on multi-day events.
Fix incorrect rendering logic at template ensuring: • Single day events only render one year string. • Multi-day events only render end-date-year string only if it's valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description
Closes
Screenshots
Before
After