Type setuptools compiler attributes #15375
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
compilerattr in commands is weird, it's never set infinalize_options, but rather inruninstead. (normally we treat anything infinalize_optionsin setuptools the same as if it's been initialized in__init__)With downstream command subclasses also intended to override
finalize_options, this meanscompilermay not be an actualCompilerclass instance yet.Tentatively opening to see ecosystem check.
This would, once again, benefit from
AnyOf: python/typing#566