conformance: allow emitting an error on missing return with Any annotation#2188
Open
JelleZijlstra wants to merge 2 commits intopython:mainfrom
Open
conformance: allow emitting an error on missing return with Any annotation#2188JelleZijlstra wants to merge 2 commits intopython:mainfrom
JelleZijlstra wants to merge 2 commits intopython:mainfrom
Conversation
…ation Pycroscope produces an error on the existing open() function in this file because it is annotated as returning Any, but doesn't have a return statement. There's some existing discussion of this case in python/mypy#10297 showing that it is intentional for mypy to not error here, but I don't think we need to prohibit type checkers from emitting an error in this case if they choose.
AlexWaygood
approved these changes
Feb 21, 2026
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
I agree that whether or not a type checker emits a lint for this pattern should have no bearing on whether or not this test passes, since this test is trying to test something wholly unrelated to that question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pycroscope produces an error on the existing open() function in this file
because it is annotated as returning Any, but doesn't have a return statement.
There's some existing discussion of this case in python/mypy#10297
showing that it is intentional for mypy to not error here, but I don't think
we need to prohibit type checkers from emitting an error in this case
if they choose.