Skip to content

Conversation

@fbarchard
Copy link
Collaborator

@fbarchard fbarchard commented Jan 2, 2026

Apple M3 uses Coll Everest v2 and Sawtooth v2 similar to Apple A17
Apple M5 uses Tilos Everest v4 and Sawtooth v4 the same as Apple A19

M3 has 3 variations that use the existing A17 pcore and ecore
M5 / A19 add v4 versions of Everest and Sawtooth

M5 Pro (Sotra) is not added

Table of M series codename/uarch

MSoc     ASoc      MSoc               pcore         ecore
Apple M1 A14       Tonga              Firestorm     Icestorm   
Apple M2 A15       Staten Rhodes      Avalanche     Blizzard
Apple M3 A16/A17   Ibiza Lobos Palma  Coll_Everest  Coll_Sawtooth
Apple M4 A17 Pro   Donan Brava        Donan_Everest Donan_Sawtooth
Apple M5 A19 Pro   Hidra Sotra        Tilos_Everest Tilos_Sawtooth

Fixes #365

@meta-cla meta-cla bot added the cla signed label Jan 2, 2026
@fbarchard fbarchard requested a review from kimishpatel January 2, 2026 23:29
@GregoryComer
Copy link
Member

Thanks. Can you resolve the build failure in cpu-info.c? I can go ahead and merge after that.

FAILED: [code=1] CMakeFiles/cpu-info.dir/tools/cpu-info.c.obj 
C:\mingw64\bin\cc.exe -DCPUINFO_SUPPORTED_PLATFORM=1 -ID:/a/cpuinfo/cpuinfo/include -O3 -DNDEBUG -std=c99 -MD -MT CMakeFiles/cpu-info.dir/tools/cpu-info.c.obj -MF CMakeFiles\cpu-info.dir\tools\cpu-info.c.obj.d -o CMakeFiles/cpu-info.dir/tools/cpu-info.c.obj -c D:/a/cpuinfo/cpuinfo/tools/cpu-info.c
D:/a/cpuinfo/cpuinfo/tools/cpu-info.c: In function 'uarch_to_string':
D:/a/cpuinfo/cpuinfo/tools/cpu-info.c:309:17: error: duplicate case value
  309 |                 case cpuinfo_uarch_tilos_everest:
      |                 ^~~~
D:/a/cpuinfo/cpuinfo/tools/cpu-info.c:305:17: note: previously used here
  305 |                 case cpuinfo_uarch_tahiti_everest:
      |                 ^~~~
D:/a/cpuinfo/cpuinfo/tools/cpu-info.c:311:17: error: duplicate case value
  311 |                 case cpuinfo_uarch_tilos_sawtooth:
      |                 ^~~~
D:/a/cpuinfo/cpuinfo/tools/cpu-info.c:307:17: note: previously used here
  307 |                 case cpuinfo_uarch_tahiti_sawtooth:
      |                 ^~~~

@fbarchard
Copy link
Collaborator Author

Fixed header to have unique values for the uarch

the git fetch pulled in another change in name.c, which looks harmless.. it avoids a switch fallthru

@GregoryComer GregoryComer merged commit 315f594 into pytorch:main Jan 7, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Apple M3 uarch to cpuinfo

2 participants