-
Notifications
You must be signed in to change notification settings - Fork 778
Cortex-M backend: Update Scalar types to be int #16322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Scalar should only used if the operator truly supports either type. Signed-off-by: Saoirse Stewart <saoirse.stewart@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16322
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 5dc1aa4 with merge base cf28248 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "release notes: none" |
|
@pytorchbot label ciflow/trunk |
|
@pytorchbot label 'partner: arm' |
| const int32_t* multipliers, | ||
| const int32_t* shifts, | ||
| const IntArrayRef multipliers, | ||
| const IntArrayRef shifts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, enhances the type safety!
One question though: IntArrayRef = ArrayRef<int64_t> ?
Different element sizes (4 bytes for int32_t vs 8 bytes for int64_t in IntArrayRef). Can you clarify if this change (Ln 170/ Ln 171) indeed is safe ?
Summary
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai