Skip to content

Conversation

@SaoirseARM
Copy link
Collaborator

@SaoirseARM SaoirseARM commented Dec 18, 2025

Summary

  • Scalar should only used if the operator truly supports either type.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

- Scalar should only used if the operator truly supports either type.

Signed-off-by: Saoirse Stewart <saoirse.stewart@arm.com>
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16322

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 5dc1aa4 with merge base cf28248 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 18, 2025
@AdrianLundell AdrianLundell requested a review from psiddh December 18, 2025 18:57
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Dec 19, 2025
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Dec 19, 2025
const int32_t* multipliers,
const int32_t* shifts,
const IntArrayRef multipliers,
const IntArrayRef shifts,
Copy link
Contributor

@psiddh psiddh Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, enhances the type safety!
One question though: IntArrayRef = ArrayRef<int64_t> ?

Different element sizes (4 bytes for int32_t vs 8 bytes for int64_t in IntArrayRef). Can you clarify if this change (Ln 170/ Ln 171) indeed is safe ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants