Skip to content

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Dec 18, 2025

Summary:

Context

Currently, the gen_vulkan_spv.py script which orchestrates compute shader compilation for the Vulkan backend uses a thread pool to help parallelize shader compilation.

However, when Claude Code is instructed to build ExecuTorch via CMake, it runs into permission issues when trying to launch threads.

As a workaround, this PR adds a setting to control the number of threads that is used during shader compilation. 1 will result in serial compilation and -1 will result in querying the number of processors available.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16325

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 92e66a0 with merge base b8916b7 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 18, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync
Copy link

meta-codesync bot commented Dec 18, 2025

@SS-JIA has imported this pull request. If you are a Meta employee, you can view this in D89497641.

@SS-JIA SS-JIA force-pushed the pr16325 branch 2 times, most recently from b88cc3e to 56f8acb Compare December 19, 2025 19:31
…build (#16325)

Summary:
## Context

Currently, the `gen_vulkan_spv.py` script which orchestrates compute shader compilation for the Vulkan backend uses a thread pool to help parallelize shader compilation.

However, when Claude Code is instructed to build ExecuTorch via CMake, it runs into permission issues when trying to launch threads.

As a workaround, this PR adds a setting to control the number of threads that is used during shader compilation. 1 will result in serial compilation and -1 will result in querying the number of processors available.


Reviewed By: manuelcandales

Differential Revision: D89497641

Pulled By: SS-JIA
@meta-codesync
Copy link

meta-codesync bot commented Dec 19, 2025

@SS-JIA has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89497641.

@meta-codesync meta-codesync bot merged commit 227ff2e into main Dec 20, 2025
164 of 170 checks passed
@meta-codesync meta-codesync bot deleted the pr16325 branch December 20, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants