Skip to content

Conversation

@metab0t
Copy link
Contributor

@metab0t metab0t commented Dec 2, 2025

Welcome to the quarto GitHub repo!

We are always happy to hear feedback from our users.

To file a pull request, please follow these instructions carefully: https://yihui.org/issue/#bug-reports

If you're a collaborator from outside quarto-dev making changes larger than a typo, please make sure you have filed an individual or corporate contributor agreement. You can send the signed copy to jj@rstudio.com.

Also, please complete and keep the checklist below.

Description

Please describe your PR here.

On Windows, we need to use utf-8 to read the json correctly.

This one line change fixes the json load error on Windows writingdocuments containing Chinese for me.

Checklist

I have (if applicable):

  • filed a contributor agreement.
  • referenced the GitHub issue this PR closes
  • updated the appropriate changelog in the PR
  • ensured the present test suite passes
  • added new tests
  • created a separate documentation PR in Quarto's website repo and linked it to this PR

@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented Dec 2, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this one !

Copilot AI review requested due to automatic review settings January 14, 2026 15:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a UTF-8 encoding issue on Windows when reading JSON input from stdin. The problem occurs when processing documents containing non-ASCII characters (e.g., Chinese), which causes JSON parsing to fail due to incorrect encoding.

Changes:

  • Added UTF-8 encoding reconfiguration for stdin before reading JSON input

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cderv
Copy link
Collaborator

cderv commented Jan 14, 2026

🤔 Why copilot is triggering now...

@cderv cderv merged commit 9c6d652 into quarto-dev:main Jan 14, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants