simplify typst-gather build #13940
Merged
simplify typst-gather build #13940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub-hosted runners have stable Rust pre-installed by default. The dtolnay/rust-toolchain action is unnecessary since configure.sh already handles building typst-gather when cargo is available. Keeps cargo cache step in quarto-dev action for faster CI builds. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove conditional cargo check - build should fail if Rust is not available rather than silently skipping typst-gather. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
- configure.sh/cmd: Copy built binary to standard tools location - Simplify cmd.ts files to only use architectureToolsPath() - prepare-dist.ts: Error if typst-gather binary is missing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
there is logic in TS to handle numbers if they get through but following the schema and using an explicit string when that's the only entry is safest and clearest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stable Rust is the default on GH runners, so we don't need any workflow steps.
(Including for the Windows launcher; we can build that on stable instead of pinned as discussed.)
Also:
typst-gatherfails to build.typst-gatherbinary gets copied to the usualbindirectory and run/dist from there.