Skip to content

imx290 : implement HCG/LCG mode #4953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gechdcb wants to merge 1 commit into from
Closed

imx290 : implement HCG/LCG mode #4953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions drivers/media/i2c/imx290.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include <linux/gpio/consumer.h>
#include <linux/i2c.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/of_device.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
Expand Down Expand Up @@ -67,6 +68,10 @@ enum imx290_clk_index {
#define IMX290_PIXEL_ARRAY_WIDTH 1937U
#define IMX290_PIXEL_ARRAY_HEIGHT 1097U

static bool hcgmode = false;
module_param(hcgmode, bool, 0664);
MODULE_PARM_DESC(hcgmode, "Enable HCG mode");

static const char * const imx290_supply_name[] = {
"vdda",
"vddd",
Expand Down Expand Up @@ -246,7 +251,6 @@ static const struct imx290_regval imx290_74_250mhz_clock_1080p[] = {

static const struct imx290_regval imx290_1080p_common_settings[] = {
/* mode settings */
{ IMX290_FR_FDG_SEL, 0x01 },
{ 0x3007, 0x00 },
{ 0x303a, 0x0c },
{ 0x3414, 0x0a },
Expand Down Expand Up @@ -330,7 +334,6 @@ static const struct imx290_regval imx290_74_250mhz_clock_720p[] = {

static const struct imx290_regval imx290_720p_common_settings[] = {
/* mode settings */
{ IMX290_FR_FDG_SEL, 0x01 },
{ 0x3007, 0x10 },
{ 0x303a, 0x06 },
{ 0x3414, 0x04 },
Expand Down Expand Up @@ -1071,6 +1074,12 @@ static int imx290_start_streaming(struct imx290 *imx290)
}

/* Apply default values of current mode */
ret = imx290_write_reg(imx290, IMX290_FR_FDG_SEL, hcgmode ? 0x11 : 0x01);
if (ret < 0) {
dev_err(imx290->dev, "Could not set current mode\n");
return ret;
}

ret = imx290_set_register_array(imx290,
imx290->current_mode->mode_data,
imx290->current_mode->mode_data_size);
Expand Down Expand Up @@ -1250,6 +1259,7 @@ static int imx290_probe(struct i2c_client *client)
const struct imx290_mode *mode;
struct imx290 *imx290;
s64 fq;
u8 max_gain;
int ret;

imx290 = devm_kzalloc(dev, sizeof(*imx290), GFP_KERNEL);
Expand Down Expand Up @@ -1332,6 +1342,16 @@ static int imx290_probe(struct i2c_client *client)
goto free_err;
}

max_gain = 100;
if (fwnode_property_present(dev_fwnode(dev), "max-gain")) {
ret = fwnode_property_read_u8(dev_fwnode(dev), "max-gain",
&max_gain);
if (ret) {
dev_err(dev, "Could not get max gain\n");
goto free_err;
}
}

ret = clk_set_rate(imx290->xclk, imx290->xclk_freq);
if (ret) {
dev_err(dev, "Could not set xclk frequency\n");
Expand Down Expand Up @@ -1364,7 +1384,7 @@ static int imx290_probe(struct i2c_client *client)
v4l2_ctrl_handler_init(&imx290->ctrls, 11);

v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops,
V4L2_CID_ANALOGUE_GAIN, 0, 100, 1, 0);
V4L2_CID_ANALOGUE_GAIN, 0, max_gain, 1, 0);

mode = imx290->current_mode;
imx290->hblank = v4l2_ctrl_new_std(&imx290->ctrls, &imx290_ctrl_ops,
Expand Down