media: i2c: imx219: fix binning and rate_factor for 480p and 1232p #7063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enum binning_mode is redundant, it only uses values from the earlier defined binning modes. Remove it. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
pelwell
reviewed
Sep 24, 2025
At a high FPS with RAW10, there is frame corruption for 480p because the rate_factor of 2 is used with the normal 2x2 bining [1]. This commit ties the rate_factor to the selected binning mode. For the 480p mode, analog 2x2 binning mode with a rate_factor of 2 is always used. For the 1232p mode the normal 2x2 binning mode is used for RAW10 while analog 2x2 binning mode is used for RAW8. [1] raspberrypi#5493 Signed-off-by: Vinay Varma <varmavinaym@gmail.com> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reworked due to upstream changes
pelwell
approved these changes
Sep 24, 2025
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Sep 27, 2025
See: raspberrypi/linux#6945 kernel: net: phy: broadcom: Add led-swap property support See: raspberrypi/linux#7060 kernel: Select internal MSI target for 32-bit DMA on Pi 5 PCIe See: raspberrypi/linux#7059 kernel: configs: Add CONFIG_VEML6030=m See: raspberrypi/linux#7052 kernel: media: i2c: imx219: Scale the pixel rate for analog binning See: raspberrypi/linux#7045 kernel: staging: vc-sm-cma: Fix field-spanning write warning See: raspberrypi/linux#7064 kernel: drm/rp1: rp1-dsi: Add support for inverting lane polarities See: raspberrypi/linux#7065 kernel: ARM: dts: Select the PL011 platform driver See: raspberrypi/linux#7023 kernel: media: i2c: imx219: fix binning and rate_factor for 480p and 1232p See: raspberrypi/linux#7063
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Sep 27, 2025
See: raspberrypi/linux#6945 kernel: net: phy: broadcom: Add led-swap property support See: raspberrypi/linux#7060 kernel: Select internal MSI target for 32-bit DMA on Pi 5 PCIe See: raspberrypi/linux#7059 kernel: configs: Add CONFIG_VEML6030=m See: raspberrypi/linux#7052 kernel: media: i2c: imx219: Scale the pixel rate for analog binning See: raspberrypi/linux#7045 kernel: staging: vc-sm-cma: Fix field-spanning write warning See: raspberrypi/linux#7064 kernel: drm/rp1: rp1-dsi: Add support for inverting lane polarities See: raspberrypi/linux#7065 kernel: ARM: dts: Select the PL011 platform driver See: raspberrypi/linux#7023 kernel: media: i2c: imx219: fix binning and rate_factor for 480p and 1232p See: raspberrypi/linux#7063
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At a high FPS with RAW10, there is frame corruption for 480p because the rate_factor of 2 is used with the normal 2x2 bining [1]. This commit ties the rate_factor to the selected binning mode. For the 480p mode, analog 2x2 binning mode with a rate_factor of 2 is always used. For the 1232p mode the normal 2x2 binning mode is used for RAW10 while analog 2x2 binning mode is used for RAW8.
[1] #5493
Reworked due to upstream changes