-
Notifications
You must be signed in to change notification settings - Fork 42
feat: export Products page as a component and consume it in apps/admin #1363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/export-invoices-page
Are you sure you want to change the base?
feat: export Products page as a component and consume it in apps/admin #1363
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pull Request Test Coverage Report for Build 21901106209Details
💛 - Coveralls |
…I to use new views structure
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
| currency={prices[0].currency} | ||
| /> | ||
| ) : onNavigateToPrices && productId ? ( | ||
| <button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets use apsara button here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope. Let's pick this in a different PR.
Move products page to
@raystack/frontier/adminSummary
Moved the products UI from
apps/admin/src/containers/products.list/intoweb/lib/admin/pages/products/as router-agnostic pages. The admin app wires routing via thin wrappers and callbacks.Changes
Lib
web/lib/admin/pages/products/—index.tsx,details.tsx,header.tsx,columns.tsx,products.module.css,types.tsx.web/lib/admin/pages/products/prices/—index.tsx,columns.tsx.@raystack/frontier/admin:ProductsPage— optional props:selectedProductId,onSelectProduct,onCloseDetail,onNavigateToPrices,appName.ProductPricesPage— optional props:productId,appName,onBreadcrumbClick.onNavigateToPrices,onBreadcrumbClick) so the lib stays router-agnostic.App
ProductsPageWithRouter— usesuseParams/useNavigate, passesonSelectProduct,onCloseDetail,onNavigateToPrices.ProductPricesPageWithRouter— usesuseParams/useNavigate, passesonBreadcrumbClickfor breadcrumb navigation.products→ product list (with optional detail sheet).products/:productId→ product list with detail forproductId.products/:productId/prices→ product prices.containers/products.list; products UI now lives in the lib.Note
To test locally, set the frontier dependency to the workspace package in
frontier/web/apps/admin/package.json:Technical details
Test plan