Skip to content

Conversation

@paanSinghCoder
Copy link
Contributor

@paanSinghCoder paanSinghCoder commented Feb 10, 2026

Summary

  • Moved the Plans page from apps/admin to lib/admin/views/plans/ using git mv where applicable to preserve history.
  • Exported PlansView from @raystack/frontier/admin as a router-agnostic view (same behaviour: list plans, client-side table with search/sort/filter, "Plans" header, plan detail in a sheet when selectedPlanId is set).
  • Added a thin PlansPage wrapper in apps/admin that renders <PlansView selectedPlanId={planId} onCloseDetail={() => navigate("/plans")} />.
  • Updated the plans and plans/:planId routes to use PlansPage; route paths and behaviour unchanged.

Test plan

  • Plans list loads with all plans.
  • Table sorting, filtering, and search work (client-side).
  • Plan ID link in the table navigates to /plans/:planId and opens the detail sheet.
  • Closing the detail sheet (or navigating to /plans) returns to the list.
  • Lib build: pnpm build in web/lib.
  • App build: pnpm build in web/apps/admin.

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment Feb 11, 2026 10:22am

@coderabbitai
Copy link

coderabbitai bot commented Feb 10, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/export-plans-page

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link

coveralls commented Feb 10, 2026

Pull Request Test Coverage Report for Build 21901150617

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.24%

Totals Coverage Status
Change from base Build 21901117416: 0.0%
Covered Lines: 16107
Relevant Lines: 42121

💛 - Coveralls

@paanSinghCoder paanSinghCoder changed the title feat: export Audit logs page as a component and consume it in apps/admin feat: export Plans page as a component and consume it in apps/admin Feb 10, 2026
@paanSinghCoder paanSinghCoder requested a review from rsbh February 10, 2026 10:16
@paanSinghCoder paanSinghCoder self-assigned this Feb 10, 2026
@paanSinghCoder paanSinghCoder added the Do not merge Label to indicate that the PR is not ready to be merged even though might be (or not) approvals. label Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do not merge Label to indicate that the PR is not ready to be merged even though might be (or not) approvals.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants