-
Notifications
You must be signed in to change notification settings - Fork 201
chore: remove dist files in npm package #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
概览从package.json的"files"数组中移除"dist"条目,减少发布的构件。此改变针对Windows安装路径问题进行优化。 变更列表
代码审查工作量估算🎯 1 (微不足道) | ⏱️ ~3 分钟
诗
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @afc163, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes the npm package by excluding the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the dist directory from the files included in the npm package. While this can reduce the package size, it's a potentially breaking change for consumers who might be using the UMD builds from that directory. My review includes a comment highlighting this and suggesting it be treated as a breaking change, which typically warrants a major version bump.
| "files": [ | ||
| "es", | ||
| "lib", | ||
| "dist", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the dist directory from the files array is a breaking change for any consumer that was relying on the UMD build (e.g., via a CDN like unpkg, or a direct script include). According to Semantic Versioning principles, a breaking change should be accompanied by a major version bump. I'd recommend bumping the version to 2.0.0 to signal this change to users.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #653 +/- ##
=======================================
Coverage 99.83% 99.83%
=======================================
Files 17 17
Lines 619 619
Branches 190 190
=======================================
Hits 618 618
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
resolve ant-design/ant-design#55859
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.