Skip to content

Conversation

@afc163
Copy link
Member

@afc163 afc163 commented Nov 25, 2025

resolve ant-design/ant-design#55859

Summary by CodeRabbit

  • 杂项
    • 优化了包分发配置,减少了发布的工件。

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Nov 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
tree-select Error Error Nov 25, 2025 3:14am

@coderabbitai
Copy link

coderabbitai bot commented Nov 25, 2025

概览

从package.json的"files"数组中移除"dist"条目,减少发布的构件。此改变针对Windows安装路径问题进行优化。

变更列表

内聚组 / 文件 变更摘要
包配置
package.json
从"files"数组移除"dist"条目,解决Windows环境下路径特殊字符导致的安装失败问题

代码审查工作量估算

🎯 1 (微不足道) | ⏱️ ~3 分钟

  • 单个文件修改,配置级别变更
  • 移除操作简单明确,无逻辑复杂性
  • 与Windows安装路径问题的关联验证需轻微关注

🐰 dist 飘然而去,
窗口不再叹息,
路径清爽如新,
兔兔为君欢呼! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR标题清晰准确地总结了主要变化:从npm包的files数组中移除dist条目,与changeset内容完全相关。
Linked Issues check ✅ Passed PR通过从package.json中移除dist条目来解决Windows安装失败问题,直接解决了issue #55859中因dist目录导致的路径问题。
Out of Scope Changes check ✅ Passed 所有代码更改都在scope范围内,仅修改package.json中的files数组,完全与linked issue相关,无无关改动。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/dist-in-pack

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b1eee9b and efc502c.

📒 Files selected for processing (1)
  • package.json (0 hunks)
💤 Files with no reviewable changes (1)
  • package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Socket Security: Pull Request Alerts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link

Summary of Changes

Hello @afc163, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes the npm package by excluding the dist directory from the published artifact. This addresses a reported issue regarding package size, ensuring that only essential files are distributed and resulting in a smaller, more efficient package for consumers.

Highlights

  • NPM Package Optimization: The dist directory has been removed from the files array in package.json, preventing it from being included when the package is published to npm. This change aims to reduce the overall size of the published package.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the dist directory from the files included in the npm package. While this can reduce the package size, it's a potentially breaking change for consumers who might be using the UMD builds from that directory. My review includes a comment highlighting this and suggesting it be treated as a breaking change, which typically warrants a major version bump.

"files": [
"es",
"lib",
"dist",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Removing the dist directory from the files array is a breaking change for any consumer that was relying on the UMD build (e.g., via a CDN like unpkg, or a direct script include). According to Semantic Versioning principles, a breaking change should be accompanied by a major version bump. I'd recommend bumping the version to 2.0.0 to signal this change to users.

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.83%. Comparing base (b1eee9b) to head (efc502c).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #653   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          17       17           
  Lines         619      619           
  Branches      190      190           
=======================================
  Hits          618      618           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@afc163 afc163 merged commit faf261f into master Nov 25, 2025
12 of 13 checks passed
@afc163 afc163 deleted the fix/dist-in-pack branch November 25, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@rc-component/steps": "~1.2.1" windows下安装失败

2 participants