chore: Add Vercel configuration for umijs framework #654
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
全局概览新增 变更详情
代码审查工作量评估🎯 1 (简单) | ⏱️ ~3 分钟
兔兔的庆祝诗
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @afc163, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Vercel configuration file to the project. The primary goal is to ensure that Vercel correctly identifies and handles the project as an Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
=======================================
Coverage 99.83% 99.83%
=======================================
Files 17 17
Lines 619 619
Branches 190 190
=======================================
Hits 618 618
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a vercel.json configuration file to enable deployments on Vercel. The configuration specifies umijs as the framework. While this may work, I've suggested a more robust configuration using @vercel/static-build to avoid potential incompatibilities between the umijs preset and the dumi tool used in this project. This change will make the deployment configuration more explicit and less prone to breaking with future updates to Vercel's framework presets.
| { | ||
| "framework": "umijs" | ||
| } |
There was a problem hiding this comment.
While dumi is based on umi, using the umijs framework preset might introduce unexpected behavior or break in the future, as the preset is optimized for umi applications, not dumi documentation sites. A more robust and explicit approach would be to use @vercel/static-build. This builder will use the now-build script from your package.json and expects the output in a dist directory, which aligns perfectly with your project's setup. This avoids reliance on a framework-specific preset that may not be fully compatible.
| { | |
| "framework": "umijs" | |
| } | |
| { | |
| "builds": [{ "src": "package.json", "use": "@vercel/static-build" }] | |
| } |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.