Android: Fix not clickable via TalkBack#1190
Open
terreng wants to merge 1 commit intoreact-native-menu:masterfrom
Open
Android: Fix not clickable via TalkBack#1190terreng wants to merge 1 commit intoreact-native-menu:masterfrom
terreng wants to merge 1 commit intoreact-native-menu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #1189 by forwarding the child's click event to the parent menu.
The issue: The menu trigger isn't clickable via TalkBack (screen reader) on Android. You can select the menu button, but clicking it does nothing. It works fine without a screen reader, and on iOS with or without VoiceOver.
Test Plan
Without the fix:
With the fix: