De-duplication for Django CSS/JS#275
Closed
Archmonger wants to merge 3 commits intoreactive-python:mainfrom
Closed
De-duplication for Django CSS/JS#275Archmonger wants to merge 3 commits intoreactive-python:mainfrom
Archmonger wants to merge 3 commits intoreactive-python:mainfrom
Conversation
Contributor
Author
|
I am currently struggling to find a justification for this feature. The current method of de-duplication would simply be loading CSS/JS in a parent component. rather than each individual child component. The original intent for this PR was to utilize this feature within #211 but I don't believe that is technologically realistic. Closing this PR since this feature appears to be unnecessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rewrite of #226
Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).