Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
import_reactjswithinhtml.head(...). As a result, this adds a few improvements:component_from_npmcan now piggy-back on ReactPy's internal ReactJS export to prevent bugs caused by ReactJS version mismatches.component_from_fileandcomponent_from_stringno longer need to be compiled/built by the user (withvite,webpack,rollup, etc) if they only use the following imports:react,react-dom,react-dom/client, andreact/jsx-runtime.hatch test --parallel). This reduces test runtime from ~150 seconds to ~20 seconds on local machines.component_from_npmcould generate aReactDOM.createRoot was called on existing rootwarning.reactpy.pyscriptcode intoreactpy.executors.pyscriptChecklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).