Fix SSR @component functions rendering under CSR components#1324
Merged
Archmonger merged 4 commits intoreactive-python:mainfrom Jan 24, 2026
Merged
Fix SSR @component functions rendering under CSR components#1324Archmonger merged 4 commits intoreactive-python:mainfrom
@component functions rendering under CSR components#1324Archmonger merged 4 commits intoreactive-python:mainfrom
Conversation
Addresses reactive-python#1323. I spent hours digging this bug down. Without this little change, it was impossible to nest a custom reactpy component (i.e. a function wrapped with the component decorator). It would yield an error along the lines of "Cannot create element with
Contributor
Author
|
I can add a test for this - hopefully soon. |
Archmonger
changed the title
Archmonger
requested changes
Jan 18, 2026
Archmonger
changed the title
@component functions rendering under CSR components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1323. Without this little change, it was impossible to nest a custom ReactPy component (i.e. a function wrapped with the component decorator) under a ReactJS web component.
Description
See code change - it's extremely simple and straightforward.
Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).