fix: Fix jest usage with mocks #3691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Jest (and other CommonJS consumers) fail when importing
@data-client/testbecause the/mocksubpath exports in@data-client/reactand@data-client/coreonly had ESM builds. When Jest tries torequire('@data-client/react/mock'), it resolves to the ESM file which usesexport *syntax, causing:Solution
Add CommonJS builds for the
/mocksubpath exports in both packages:@data-client/core: Addedsrc/mock/index.tsto rollup CJS build, outputsdist/mock.js@data-client/react: Addedsrc/mock/index.tsto rollup CJS build, outputsdist/mock.jspackage.jsonexports in both packages to include"require"condition pointing to the new CJS bundlesChanges
@data-client/corerollup.config.mjs@data-client/corepackage.jsonrequirecondition to./mockexport@data-client/reactrollup.config.mjs@data-client/reactpackage.jsonrequirecondition to./mockexport